linux-kernel - Re: [PATCH] alsa: ac97_patch make functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Sep 2008 08:39:48 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] alsa: ac97_patch make functions static

At Fri, 29 Aug 2008 13:32:00 -0700,
Harvey Harrison wrote:
> 
> Only used in ac97_codec by including ac97_patch.c directly, effectively static
> 
> Found by sparse:
> sound/pci/ac97/ac97_patch.c:3551:5: warning: symbol 'patch_vt1617a' was not declared. Should it be static?
> sound/pci/ac97/ac97_patch.c:3767:5: warning: symbol 'patch_vt1618' was not declared. Should it be static?
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

Thanks, applied now.


Takashi


> ---
>  sound/pci/ac97/ac97_patch.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
> index d0cab1d..6ce3cbe 100644
> --- a/sound/pci/ac97/ac97_patch.c
> +++ b/sound/pci/ac97/ac97_patch.c
> @@ -3548,7 +3548,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1617a[] = {
>  	},
>  };
>  
> -int patch_vt1617a(struct snd_ac97 * ac97)
> +static int patch_vt1617a(struct snd_ac97 * ac97)
>  {
>  	int err = 0;
>  	int val;
> @@ -3764,7 +3764,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1618[] = {
>  	}
>  };
>  
> -int patch_vt1618(struct snd_ac97 *ac97)
> +static int patch_vt1618(struct snd_ac97 *ac97)
>  {
>  	return patch_build_controls(ac97, snd_ac97_controls_vt1618,
>  				    ARRAY_SIZE(snd_ac97_controls_vt1618));
> -- 
> 1.6.0.366.gf9ffa8
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/