linux-kernel - Re: [TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class->needs_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Sep 2008 16:36:04 -0400
From:	Gregory Haskins <gregory.haskins@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Gregory Haskins <ghaskins@...ell.com>, mingo@...e.hu,
	peterz@...radead.org, linux-kernel@...r.kernel.org,
	linux-rt-users@...r.kernel.org, npiggin@...e.de
Subject: Re: [TIP/SCHED/DEVEL PATCH v3 4/6] sched: add sched_class->needs_post_schedule()
 member

Steven Rostedt wrote:
> On Thu, 4 Sep 2008, Gregory Haskins wrote:
>   
>> diff --git a/kernel/sched.c b/kernel/sched.c
>> index af4c6fa..ddc3877 100644
>> --- a/kernel/sched.c
>> +++ b/kernel/sched.c
>> @@ -2525,6 +2525,14 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev)
>>  {
>>  	struct mm_struct *mm = rq->prev_mm;
>>  	long prev_state;
>> +#ifdef CONFIG_SMP
>> +	int post_schedule = 0;
>> +
>> +	if (current->sched_class->needs_post_schedule) {
>> +		BUG_ON(!current->sched_class->post_schedule);
>>     
>
> The only one to ever hit this BUG_ON is a kernel developer creating a new
> sched class. Since they should be smart enough to figure out why they get 
> a segv later on, we really don't need it. Because this BUG_ON is also in 
> a hot path, I strongly suggest nuking it.
>   
Ack.  Will do a respin after you review the last few patches.

-Greg



Download attachment "signature.asc" of type "application/pgp-signature" (258 bytes)