linux-kernel - Re: [PATCH 0/18] linux infrared remote control drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 10:32:50 +0200
From:	Janne Grunau <j@...nau.net>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Jarod Wilson <jwilson@...hat.com>, linux-kernel@...r.kernel.org,
	Jarod Wilson <jarod@...hat.com>,
	Christoph Bartelmus <lirc@...telmus.de>,
	Eric Sandeen <esandeen@...hat.com>,
	Mario Limonciello <superm1@...ntu.com>
Subject: Re: [PATCH 0/18] linux infrared remote control drivers

On Tuesday 09 September 2008 09:06:03 Alexey Dobriyan wrote:
>
> All version.h and autoconf.h inclusions aren't needed.

I'll remove them.

> #ifdef MODULE is gross and very old. Don't need that. Just use
>
> 	static int __init x_init(void)
> 	{
> 		...
> 	}
>
> 	static void __exit x_exit(void)
> 	{
> 		...
> 	}
> 	module_init(x_init);
> 	module_exit(x_exit);
> 	MODULE_LICENSE
> 		...
>
> It will work correctly in modular and built-in case.

Will do so.

> Static number of devices is simple but how about adding them
> dynamically.

Will have a look

Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/