linux-kernel - Re: [PATCH 1/5] drivers/infiniband/hw: Drop code after return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Sep 2008 15:46:11 +0200
From:	"Richard Genoud" <richard.genoud@...il.com>
To:	"Julia Lawall" <julia@...u.dk>
Cc:	rolandd@...co.com, sean.hefty@...el.com, hal.rosenstock@...il.com,
	general@...ts.openfabrics.org, vigneshbabu@...il.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/5] drivers/infiniband/hw: Drop code after return

2008/9/11 Julia Lawall <julia@...u.dk>:
> From: Julia Lawall <julia@...u.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
Reviewed-by: Richard Genoud <richard.genoud@...il.com>
> ---
>  drivers/infiniband/hw/amso1100/c2_provider.c |    1 -
>  drivers/infiniband/hw/nes/nes_verbs.c        |    3 ---
>  2 files changed, 4 deletions(-)
>
> diff -u -p a/drivers/infiniband/hw/amso1100/c2_provider.c b/drivers/infiniband/hw/amso1100/c2_provider.c
> --- a/drivers/infiniband/hw/amso1100/c2_provider.c
> +++ b/drivers/infiniband/hw/amso1100/c2_provider.c
> @@ -272,7 +272,6 @@ static struct ib_qp *c2_create_qp(struct
>                pr_debug("%s: Invalid QP type: %d\n", __func__,
>                        init_attr->qp_type);
>                return ERR_PTR(-EINVAL);
> -               break;
>        }
>
>        if (err) {
> diff -u -p a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c
> --- a/drivers/infiniband/hw/nes/nes_verbs.c
> +++ b/drivers/infiniband/hw/nes/nes_verbs.c
> @@ -1467,7 +1467,6 @@ static struct ib_qp *nes_create_qp(struc
>                default:
>                        nes_debug(NES_DBG_QP, "Invalid QP type: %d\n", init_attr->qp_type);
>                        return ERR_PTR(-EINVAL);
> -                       break;
>        }
>
>        /* update the QP table */
> @@ -2498,7 +2497,6 @@ static struct ib_mr *nes_reg_user_mr(str
>                        nes_debug(NES_DBG_MR, "Leaving, ibmr=%p", ibmr);
>
>                        return ibmr;
> -                       break;
>                case IWNES_MEMREG_TYPE_QP:
>                case IWNES_MEMREG_TYPE_CQ:
>                        nespbl = kzalloc(sizeof(*nespbl), GFP_KERNEL);
> @@ -2572,7 +2570,6 @@ static struct ib_mr *nes_reg_user_mr(str
>                        nesmr->ibmr.lkey = -1;
>                        nesmr->mode = req.reg_type;
>                        return &nesmr->ibmr;
> -                       break;
>        }
>
>        return ERR_PTR(-ENOSYS);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/