linux-kernel - Re: [PATCH 1/4] 24-bit types: typedef and functions for accessing 3-byte arrays as integers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Sep 2008 07:12:57 -0700
From:	"Chris Leech" <christopher.leech@...el.com>
To:	"Boaz Harrosh" <bharrosh@...asas.com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	jfs-discussion@...ts.sourceforge.net,
	"Harvey Harrison" <harvey.harrison@...il.com>
Subject: Re: [PATCH 1/4] 24-bit types: typedef and functions for accessing 3-byte arrays as integers

On Thu, Sep 11, 2008 at 1:03 AM, Boaz Harrosh <bharrosh@...asas.com> wrote:
>> diff --git a/fs/jfs/endian24.h b/fs/jfs/endian24.h
>> index fa92f7f..45b6397 100644
>> --- a/fs/jfs/endian24.h
>> +++ b/fs/jfs/endian24.h
>> @@ -33,6 +33,9 @@
>>               ((__x & (__u32)0x00ff0000UL) >> 16) )); \
>>  })
>>
>> +#undef __cpu_to_le24
>> +#undef __le24_to_cpu
>> +
>
> Does #undef also work on inline functions? I didn't know that

No, it doesn't and those two lines don't do anything.  The two below
do, so this file gets touched anyway, and the JFS patch deletes the
entire file.  I'll fix this is there's some other reason to redo the
patchset again.

>>  #if (defined(__KERNEL__) && defined(__LITTLE_ENDIAN)) || (defined(__BYTE_ORDER) && (__BYTE_ORDER == __LITTLE_ENDIAN))
>>       #define __cpu_to_le24(x) ((__u32)(x))
>>       #define __le24_to_cpu(x) ((__u32)(x))
>> @@ -42,6 +45,8 @@
>>  #endif
>>
>>  #ifdef __KERNEL__
>> +     #undef cpu_to_le24
>> +     #undef le24_to_cpu
>>       #define cpu_to_le24 __cpu_to_le24
>>       #define le24_to_cpu __le24_to_cpu
>>  #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/