linux-kernel - Re: [PATCH 2/3] [MTD] physmap.c: Add #endif comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Sep 2008 12:46:41 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Zev Weiss <zevweiss@...il.com>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] [MTD] physmap.c: Add #endif comments

On Fri, Sep 12, 2008 at 11:33:03PM -0700, Zev Weiss wrote:

> Adding comments to a few of the less painfully-obvious #endifs.
> 
> Signed-off-by: Zev Weiss <zevweiss@...il.com>
> ---
>   drivers/mtd/maps/physmap.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> index 6fba0d4..49e2039 100644
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -244,7 +244,7 @@ static void physmap_flash_shutdown(struct platform_device *dev)
>   #define physmap_flash_suspend NULL
>   #define physmap_flash_resume NULL
>   #define physmap_flash_shutdown NULL
> -#endif
> +#endif /* CONFIG_PM */
> 
>   static struct platform_driver physmap_flash_driver = {
>   	.probe		= physmap_flash_probe,
> @@ -302,8 +302,8 @@ void physmap_set_partitions(struct mtd_partition *parts, int
> num_parts)
>   	physmap_flash_data.nr_parts = num_parts;
>   	physmap_flash_data.parts = parts;
>   }
> -#endif
> -#endif
> +#endif /* CONFIG_MTD_PARTITIONS */
> +#endif /* PHYSMAP_COMPAT */

I thought that this was frowned upon.  (I don't like it myself, and
my editor is perfectly well capable of pointing out to me which ifdef
matches up with which endif.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/