linux-kernel - Re: [PATCH 1/3] [MTD] physmap.c: Check return of platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2008 23:43:04 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Zev Weiss <zevweiss@...il.com>, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] [MTD] physmap.c: Check return of	platform_device_register()

Hello.

Andrew Morton wrote:

>>The PHYSMAP_COMPAT code had been ignoring the return value of
>>platform_device_register() in the physmap_init() function.

>>Signed-off-by: Zev Weiss <zevweiss@...il.com>
[...]
>>diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
>>index 42d844f..6fba0d4 100644
>>--- a/drivers/mtd/maps/physmap.c
>>+++ b/drivers/mtd/maps/physmap.c
>>@@ -312,7 +312,7 @@ static int __init physmap_init(void)
>>  	err = platform_driver_register(&physmap_flash_driver);
>>  #ifdef PHYSMAP_COMPAT
>>  	if (err == 0)
>>-		platform_device_register(&physmap_flash);
>>+		err = platform_device_register(&physmap_flash);
>>  #endif
>>
>>  	return err;

> Your email client is performing space-stuffing, thus making the patches
> unapplyable.

    Er... are you sure? The patch looks alright tab wise, even after quoting...

> Presumably we should run platform_driver_unregister() if the
> platform_device_register() failed.

    Why is that? There could be "normal" platform devices out there...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/