linux-kernel - Re: [PATCH] x86: x86_{phys,virt}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Sep 2008 11:10:03 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Beulich <jbeulich@...ell.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3)

* Ingo Molnar <mingo@...e.hu> wrote:

> > Make the x86_{phys,virt}_bits common for 32- and 64-bits, and use 
> > the former in ioremap's phys_addr_valid() check also on 32bit/PAE.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> 
> applied to tip/x86/core, thanks Jan.

hm, this commit quickly broke a -tip testsystem. The system booted up 
fine but had no networking afterwards. (the eth0 interface came up fine 
but no interrupts were emitted)

i've pushed out the bad tree into tip/tmp.virt_bits.bad. The bad config 
is attached.

just check out tip/tmp.virt_bits.bad, boot into the kernel and see 
forcedeth networking break (if you have a box with forcedeth). It's 
reproducible. I've attached a 'good' and a 'bad' boot log as well.

the 2.6.27-rc6-tip-00469-g09375dc-dirty kernel (boot.good) had your 
commit reverted.

	Ingo

View attachment "config-Thu_Sep_18_09_52_46_CEST_2008.bad" of type "text/plain" (53901 bytes)

Download attachment "boot.good.bz2" of type "application/x-bzip2" (20154 bytes)

Download attachment "boot.bad.bz2" of type "application/x-bzip2" (20572 bytes)