linux-kernel - Re: [PATCH] x86: suppress trivial sparse signedness warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2008 19:46:56 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: suppress trivial sparse signedness warnings

This should probably go to Steven...

* Harvey Harrison (harvey.harrison@...il.com) wrote:
> Could just as easily change the three casts to cast to the correct
> type...this patch changes the type of ftrace_nop instead.
> 
> Supresses sparse warnings:
> arch/x86/kernel/ftrace.c:157:14: warning: incorrect type in assignment (different signedness)
> arch/x86/kernel/ftrace.c:157:14:    expected long *static [toplevel] ftrace_nop
> arch/x86/kernel/ftrace.c:157:14:    got unsigned long *<noident>
> arch/x86/kernel/ftrace.c:161:14: warning: incorrect type in assignment (different signedness)
> arch/x86/kernel/ftrace.c:161:14:    expected long *static [toplevel] ftrace_nop
> arch/x86/kernel/ftrace.c:161:14:    got unsigned long *<noident>
> arch/x86/kernel/ftrace.c:165:14: warning: incorrect type in assignment (different signedness)
> arch/x86/kernel/ftrace.c:165:14:    expected long *static [toplevel] ftrace_nop
> arch/x86/kernel/ftrace.c:165:14:    got unsigned long *<noident>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  arch/x86/kernel/ftrace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 082d996..66d9002 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -22,7 +22,7 @@
>  
>  
>  /* Long is fine, even if it is only 4 bytes ;-) */
> -static long *ftrace_nop;
> +static unsigned long *ftrace_nop;
>  
>  union ftrace_code_union {
>  	char code[MCOUNT_INSN_SIZE];
> -- 
> 1.6.0.2.471.g47a76
> 
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/