linux-kernel - Re: [PATCH 3/7] pci: using %pF in quirks.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Sep 2008 09:20:06 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>, Len Brown <lenb@...nel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 3/7] pci: using %pF in quirks.c

On Thursday, September 25, 2008 7:56 am Bjorn Helgaas wrote:
> On Wednesday 24 September 2008 08:04:33 pm Yinghai Lu wrote:
> > Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
> > ---
> >  drivers/pci/quirks.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 1f26712..addf2db 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -1689,8 +1689,7 @@ static void pci_do_fixups(struct pci_dev *dev,
> > struct pci_fixup *f, struct pci_f if ((f->vendor == dev->vendor ||
> > f->vendor == (u16) PCI_ANY_ID) && (f->device == dev->device || f->device
> > == (u16) PCI_ANY_ID)) { #ifdef DEBUG
> > -			dev_dbg(&dev->dev, "calling ");
> > -			print_fn_descriptor_symbol("%s\n", f->hook);
> > +			dev_dbg(&dev->dev, "calling %pF\n", f->hook);
> >  #endif
> >  			f->hook(dev);
> >  		}
>
> I posted a similar patch already:
>   http://lkml.org/lkml/2008/8/22/178
>
> Maybe mine was too complicated because it touched more files at once.
> Regardless, we need to remove the #ifdef DEBUG because it's no longer
> necessary.

Yeah you sent it to Andrew and it touched several files; maybe I shouldn't 
have ignored it. :)

Anyway I'll fix up the #ifdefs in my linux-next branch.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/