linux-kernel - Re: [patch] cciss: Fix cciss SCSI rescan code to better notice device changes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Oct 2008 10:12:33 -0500
From:	scameron@...rdog.cca.cpqcorp.net
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, mike.miller@...com, axboe@...nel.dk
Subject: Re: [patch] cciss: Fix cciss SCSI rescan code to better notice device changes.

On Fri, Sep 19, 2008 at 05:19:31PM -0700, Andrew Morton wrote:
> On Thu, 18 Sep 2008 15:07:44 -0500
[...] 
> y'know, it would be a lot simpler to just do
> 
> 	*sd = *device;
> 
> a few lines up, before assigning sd->bus/target/lun.
> 
> Putting these:
> 
> @@ -66,6 +66,10 @@ struct cciss_scsi_dev_t {
>  	int devtype;
>  	int bus, target, lun;		/* as presented to the OS */
>  	unsigned char scsi3addr[8];	/* as presented to the HW */
> +	unsigned char device_id[16];	/* from inquiry pg. 0x83 */
> +	unsigned char vendor[8];	/* bytes 8-15 of inquiry data */
> +	unsigned char model[16];	/* bytes 16-31 of inquiry data */
> +	unsigned char revision[4];	/* bytes 32-35 of inquiry data */
>  };
> 
> into a separate nested structure might make that neater still.
> 
[... and a bunch of other helpful comments. ]


Sorry for the slow reply, I've been on vacation.

Thanks for looking over my patch.  I'll try to make a 
patch to incorporate your suggestions.

> didn't cciss_scsi_add_entry() just do that?  I didn't look too closely,
> so maybe it didn't, and we're taking two copies for some reason.
> Please double-chec

I think you're right about that, good catch.

-- steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/