linux-kernel - Re: [PATCH 2/2] x86: mtrr_cleanup try gran

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Oct 2008 09:38:35 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	J.A. Magallón <jamagallon@....com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M


* Yinghai Lu <yinghai@...nel.org> wrote:

> > boundary handling may have problem...
> 
> can you try
> 
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index ef64128..70beb13 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -1044,7 +1044,7 @@ second_try:
>                 hole_sizek = range0_sizek - state->range_sizek - second_sizek;
> 
>                 /* hole size should be less than half of range0 size */
> -               if (hole_sizek > (range0_sizek >> 1) &&
> +               if (hole_sizek >= (range0_sizek >> 1) &&
>                     range0_sizek >= chunk_sizek) {

applied to tip/x86/mtrr, thanks Yinghai!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/