lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 4 Oct 2008 01:45:28 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arjan van de Ven <arjan@...radead.org>
cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: Add a C-state tracer to help power
 optimization


On Fri, 3 Oct 2008, Arjan van de Ven wrote:

> On Fri, 3 Oct 2008 20:32:51 -0400 (EDT)
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > 
> > Hi Arjan,
> > 
> > Very nice! I just have a few comments below.
> 
> since this is my first tracer.... I would suggest having a "golden
> example" one that people can copy (it seems I copied a less than
> perfect one ;-)... maybe a trace_example.c ?

Yeah, that would make sense to have.  People are starting to come
up with so many different tracers, I'm not sure what a golden
example would look like :-/

Some of my comments came about just noticing what you did and realized
that there's other ways to do it. I didn't think about those other
ways until I looked at your code ;-)

> 
> I'll look into your comments tomorrow when I'm more awake.

I'll comment more when I'm more awake. But that may not be until Monday.
Putting in 16 hour days during the week, my wife puts her foot down and
keeps me away from the computer during the weekend.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ