linux-kernel - Re: [patch] fix printk format typo in boot ftracer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 5 Oct 2008 11:51:34 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Frédéric Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] fix printk format typo in boot ftracer.


* Arjan van de Ven <arjan@...radead.org> wrote:

> On Sat, 4 Oct 2008 22:58:12 +0200
> "Frédéric Weisbecker" <fweisbec@...il.com> wrote:
> 
> > > -               ret = trace_seq_printf(s, "[%5ld.%06ld] initcall %s
> > > "
> > > +               ret = trace_seq_printf(s, "[%5ld.%09ld] initcall %s
> > > " "returned %d after %lld msecs\n",
> > >                                          rettime.tv_sec,
> > >                                          rettime.tv_nsec,
> > 
> > I picked these formats from the printk.c time formatting. But you're
> > right, 09 would give us the whole nano precision.
> 
> it's more than precision, it's correctness.
> 
> doing "0.%02i" will do
> 0.100  if you pass it 100 and
> 0.10   if you pass it 10
> 
> and most off the time, except the first 0.1 seconds, you'll be passing
> it 9 digits, but the first 0.1 seconds.. the %06 will just give really
> incorrect results.

applied to tip/tracing/core, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/