linux-kernel - Re: [PATCH] x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2008 07:19:28 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andreas Herrmann <andreas.herrmann3@....com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Andi Kleen <andi@...stfloor.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>,
	Jason Vas Dias <jason.vas.dias@...il.com>
Subject: Re: [PATCH] x86: SB450: skip IRQ0 override if it is not routed to
	INT2 of IOAPIC

On Tue, Oct 07, 2008 at 06:57:57AM +0200, Ingo Molnar wrote:
> 
> * Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
> 
> > On Tue, Oct 07, 2008 at 05:41:32AM +0200, Ingo Molnar wrote:
> > > 
> > > * Andreas Herrmann <andreas.herrmann3@....com> wrote:
> > > 
> > > > So, let's work around BIOS bugs in Linux then ...
> > > > 
> > > > Following patch is almost untested -- especially I didn't get my hands 
> > > > on one of the HP Laptops with broken DSDT.
> > > [...]
> > > > On some HP nx6... laptops (e.g. nx6325) BIOS reports an IRQ0 override 
> > > > but the SB450 chipset is configured such that timer interrupts goe to 
> > > > INT0 of IOAPIC.
> > > > 
> > > > Check IRQ0 routing and if it is routed to INT0 of IOAPIC skip the 
> > > > timer override.
> > > > 
> > > > Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>
> > > >
> > > > ---
> > > >  arch/x86/kernel/early-quirks.c |   48 ++++++++++++++++++++++++++++++++++++++++
> > > >  1 files changed, 48 insertions(+), 0 deletions(-)
> > > 
> > > very nice, thanks Andreas! Applied to tip/x86/quirks. This PCI ID based 
> > > quirk should be more complete than DMI matches.
> > > 
> > 
> > You may add 'Tested by: Dmitry Torokhov <dtor@...l.ru> on nx6115'
> > It works fine here with Andreas patch applied and with Rafael's patch
> > dropped.
> >
> > Thanks Andreas!
> 
> ok, added your Tested-by to the changelog, thanks.
> 
> I also applied the patch below to deprioritize the DMI quirks for this 
> problem (without actually removing them, yet). Could you please check 
> whether latest tip/master:
> 
>   http://people.redhat.com/mingo/tip.git/README
> 
> boots fine out of box and that the WARN() does not trigger?
> 

While I did not test tip/master I applied this patch on top of Andreas's
patch and the warning, as expected, did not trigger.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/