linux-kernel - Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2008 13:19:27 -0700
From:	Mark Fasheh <mfasheh@...e.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, joel.becker@...cle.com,
	ocfs2-devel@....oracle.com, linux-fsdevel@...r.kernel.org,
	tao.ma@...cle.com
Subject: Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

On Wed, Oct 01, 2008 at 11:12:01PM -0700, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh@...e.com> wrote:
> > +	void *private;
> >  };
> >  
> >  static void ocfs2_dinode_set_last_eb_blk(struct ocfs2_extent_tree *et,
> > @@ -136,9 +137,50 @@ static struct ocfs2_extent_tree_operations ocfs2_dinode_et_ops = {
> >  	.sanity_check		= ocfs2_dinode_sanity_check,
> >  };
> >  
> > +static void ocfs2_xattr_value_set_last_eb_blk(struct ocfs2_extent_tree *et,
> > +					      u64 blkno)
> > +{
> > +	struct ocfs2_xattr_value_root *xv =
> > +		(struct ocfs2_xattr_value_root *)et->private;
> 
> unneeded and undesirable cast of void*
> 
> > +	xv->xr_last_eb_blk = cpu_to_le64(blkno);
> > +}
> > +
> > +static u64 ocfs2_xattr_value_get_last_eb_blk(struct ocfs2_extent_tree *et)
> > +{
> > +	struct ocfs2_xattr_value_root *xv =
> > +		(struct ocfs2_xattr_value_root *) et->private;
> 
> many etceteras.

Thanks, luckily though, it seems these got fixed later in the series :)
	--Mark

--
Mark Fasheh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/