linux-kernel - Re: [PATCH] HPET: Remove spurious HPET busy warning message.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 09:26:40 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David John <davidjon@...ontk.org>
Cc:	clemens@...isch.de, venkatesh.pallipadi@...el.com, vojtech@...e.cz,
	bob.picco@...com, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] HPET: Remove spurious HPET busy warning message.


* David John <davidjon@...ontk.org> wrote:

> On x86 systems with CONFIG_HPET_TIMER enabled, when
> the HPET driver (drivers/char/hpet.c) is loaded,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
> 
> Signed-off-by: David John <davidjon@...ontk.org>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
> ---
>  drivers/char/hpet.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
>  		hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>  
>  		if (hpet_is_known(hdp)) {
> -			printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> -				__func__, hdp->hd_phys_address);
>  			iounmap(hdp->hd_address);
>  			return AE_ALREADY_EXISTS;
>  		}
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
>  						HPET_RANGE_SIZE);
>  
>  		if (hpet_is_known(hdp)) {
> -			printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> -				__func__, hdp->hd_phys_address);
>  			iounmap(hdp->hd_address);
>  			return AE_ALREADY_EXISTS;
>  		}

applied to tip/timers/hpet, thanks John!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/