lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Oct 2008 10:47:12 +0200 From: Christian Borntraeger <borntraeger@...ibm.com> To: benh@...nel.crashing.org Cc: Linux PPC devel <linuxppc-dev@...abs.org>, Virtualization Mailing List <virtualization@...ts.osdl.org>, Jeremy Fitzhardinge <jeremy@...p.org>, Rusty Russell <rusty@...tcorp.com.au>, LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu> Subject: Re: [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks Am Montag, 13. Oktober 2008 schrieb Benjamin Herrenschmidt: > > > if (--hp->count == 0) { > > - if (hp->ops->notifier_del) > > - hp->ops->notifier_del(hp, hp->data); > > - > > /* We are done with the tty pointer now. */ > > hp->tty = NULL; > > spin_unlock_irqrestore(&hp->lock, flags); > > > > + if (hp->ops->notifier_del) > > + hp->ops->notifier_del(hp, hp->data); > > + > > I will try. Of course the risk here is that the interrupt happens > after we set hp->tty to NULL, so we probably need to check within the > interrupt handler for a NULL tty. I haven't checked if that's the case > (I'm not in front of the code right now). Even the old code (without my patch) was setting hp->tty to NULL before doing the irq_free, so that should be ok. Christian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists