linux-kernel - Re: [PATCH] Fix broken debug output reserve_region_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Oct 2008 19:54:33 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	benh@...nel.crashing.org
CC:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	yhlu.kernel@...il.com
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()

Benjamin Herrenschmidt wrote:
>>>
>> I really think Linus' solution (add a resource printf modifier, that can 
>> contain the whole format) is much better.
> 
> I agree. In fact I may even have a patch somewhere for that. 
> 
> It has to be a pointer tho, thus what do we want ? Something that takes
> a pointer to a resource_size_t or to a whole struct resource ? In the
> later case, do we want to print the whole flags too ?
> 

Linus already posted a patch.  He took a struct resource
and printed it as a range.  I pointed out that we should use the flags 
to determine formatting options, e.g. I/O space is only 16 bits on x86.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/