linux-kernel - Re: [GIT] HID patches for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2008 12:02:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jiri Slaby <jirislaby@...il.com>,
	Adrian Bunk <bunk@...nel.org>,
	Vegard Nossum <vegard.nossum@...il.com>
Subject: Re: [GIT] HID patches for 2.6.28

* Jiri Kosina <jkosina@...e.cz> wrote:

> On Wed, 15 Oct 2008, Ingo Molnar wrote:
> 
> > this or the I2C updates cause widespread build failures in latest -git:
> 
> For the usbhid_set_leds(), Adrian has already sent me a fix [1]. 
> Still, I would like to understand whether this failure is bug or 
> feature in select/depends handling in Kconfig, because it seems to 
> behave differently from what I was expecting.

yes, it's a kconfig bug: Kconfig must either not allow complex selects 
(during its initial parsing pass of the Kconfig dependnecy tree) or 
handle the dependencies correctly.

The current "allow them silently and pepper the kernel with build 
errors" approach is obviously silly.

We already have over 100 bugfixes in the tree from the past 3 years due 
to kconfig's inability to figure out the correct dependencies. (count: 
rising steadily)

Changes to the Kconfig tool to address this design bug did not get 
picked up. See for example this quick patch from Vegard half a year ago:

  http://lkml.org/lkml/2008/5/4/13

that patch was not adopted and the config options in the warning log 
were later on frequent participants in build failures and subsequent 
stream of trivial fixes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/