linux-kernel - Re: sparc64 allmodconfig build failure...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Oct 2008 00:05:46 +0200 (CEST)
From:	Sven Wegener <sven.wegener@...aler.net>
To:	David Miller <davem@...emloft.net>
cc:	adobriyan@...il.com, davej@...hat.com,
	linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: sparc64 allmodconfig build failure...

On Tue, 14 Oct 2008, David Miller wrote:

> From: Sven Wegener <sven.wegener@...aler.net>
> Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)
> 
> > Yeah, with the default governor being any of supported governors, we
> > either need some ugly #ifdef mess to only export the governor that
> > is selected or just revert to the old code, which unconditionally
> > exports all governors. Or something like the patch below. With the
> > additional modules that I oversaw and that require the export, I'm
> > fine with just reverting the commit, although I think that
> > encapsulating the default governor decision in a built-in function
> > is cleaner than having modules reference different symbols depending
> > on configuration.
> 
> Personally I prefer the revert.

Fine with me. Dave J. or Linus, please revert 
c4d14bc0bb5d13e316890651ae4518b764c3344c, because it breaks allmodconfig 
as reported by David Miller on architectures that have cpufreq code that 
can be build as a module. All ways to only export the default governor are 
a ifdef mess and ugly, let's just revert the commit.

Thanks,
Sven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/