linux-kernel - Re: [PATCH] declare vmlist to fix ia64 build breakage in kexec core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Oct 2008 17:52:58 -0600
From:	Alex Chiang <achiang@...com>
To:	ebiederm@...ssion.com, oomichi@....nes.nec.co.jp,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	tony.luck@...el.com
Subject: Re: [PATCH] declare vmlist to fix ia64 build breakage in kexec core

Oh whoops, I see that Tony Luck already sent a patch for this
directly to Linus.

[Sorry for the noise, but I didn't realize this until I decided
to browse through my lkml folder, as Tony's patch hasn't been
pushed out yet.]

/ac

* Alex Chiang <achiang@...com>:
> Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add
> vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the
> ia64 build in this fashion:
> 
> kernel/kexec.c: In function `crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: dereferencing pointer to incomplete type
> make[1]: *** [kernel/kexec.o] Error 1
> 
> Adding the proper include fixes the build.
> 
> Signed-off-by: Alex Chiang <achiang@...com>
> ---
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
>  #include <linux/pm.h>
>  #include <linux/cpu.h>
>  #include <linux/console.h>
> +#include <linux/vmalloc.h>
>  
>  #include <asm/page.h>
>  #include <asm/uaccess.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/