linux-kernel - Re: [PATCH v5] HPET: Remove the BKL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2008 17:22:13 +0530
From:	David John <davidjon@...ontk.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	linux-kernel@...r.kernel.org, venkatesh.pallipadi@...el.com,
	tglx@...utronix.de, andi@...stfloor.org
Subject: Re: [PATCH v5] HPET: Remove the BKL.

Ingo Molnar wrote:
> * David John <davidjon@...ontk.org> wrote:
> 
>> Remove calls to the BKL as concurrent access is protected
>> by the spinlock hpet_lock.
>>
>> Signed-off-by: David John <davidjon@...ontk.org>
>> ---
>>  drivers/char/hpet.c |   41 ++++++++++++++++++++++++-----------------
>>  1 files changed, 24 insertions(+), 17 deletions(-)
> 
> this patch still needs to add locking documentation commits to hpet.c, 
> which shows that you considered all the locking changes that happen due 
> to dropping the BKL. Most of this code runs very rarely so there's 
> little chance that races will be caught in practice in any debuggable 
> manner.
> 
> 	Ingo
> 

Ok, will do this. Can you also check the RTC patch I sent that removes
the BKL from the RTC user space driver? The locking is already done,
only the BKL calls needed to be removed.

David.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/