linux-kernel - [PATCH] <linux/pci.h> needs <linux/io.h> for ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2008 08:50:19 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	ArjanvandeVen <arjan@...radead.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
cc:	linux-pci@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: [PATCH] <linux/pci.h> needs <linux/io.h> for ioremap_nocache()

commit aa42d7c6138afdc54f74e971456a0fbfec16b77b ("PCI: introduce an
pci_ioremap(pdev, barnr) function") added a static inline function that calls
ioremap_nocache(), causing a compile error on m68k:

| In file included from drivers/ide/ide.c:58:
| include/linux/pci.h: In function 'pci_ioremap_bar':
| include/linux/pci.h:1132: error: implicit declaration of function 'ioremap_nocache'
| include/linux/pci.h:1133: warning: return makes pointer from integer without a cast
| In file included from include/linux/bio.h:30,
|                  from include/linux/blkdev.h:17,
|                  from include/linux/ide.h:13,
|                  from drivers/ide/ide.c:59:

Include <linux/io.h> to provide the prototype for ioremap_nocache().

Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
---
FWIW...
Discovered in the linux-next builds on Oct 21, which was actually the one of
Oct 20 (Ozlabs time)
Discovered in the mainline builds two day later

 include/linux/pci.h |    1 +
 1 file changed, 1 insertion(+)

--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -44,6 +44,7 @@
 
 #include <linux/types.h>
 #include <linux/init.h>
+#include <linux/io.h>
 #include <linux/ioport.h>
 #include <linux/list.h>
 #include <linux/compiler.h>

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/