linux-kernel - Re: [bug] Re: [PATCH 00/35] cpumask: Replace cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Oct 2008 10:01:53 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Mike Travis <travis@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [bug] Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask

On Thursday 23 October 2008 23:55:29 Ingo Molnar wrote:
> ok, the new cpumask code blew up in -tip testing, with various sorts of
> slab corruptions during scheduler init:
...
> i suspect it's due to:
>
> 01b8bd9: sched: cpumask: get rid of boutique sched.c allocations, use
> cpumask_va

Just drop it.  It's a conversion, so it doesn't really belong in this "new 
API" stuff.  Nothing depends on it, and we need to be sure it's that which is 
causing the blowup.

Oh, and here's (one) problem:

		*nodemask = node_to_cpumask(cpu_to_node(i));

This is an old-style cpumask_t assigment, but nodemask wasn't allocated 
NR_CPUS bits if CONFIG_CPUMASK_OFFSTACK.  This is why assignment is banned 
(and will eventually fail compile), but that conversion hasn't been done on 
sched.c yet, so this patch is ahead of its time.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/