linux-kernel - Re: [PATCH] fix allmodconfig breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Oct 2008 08:32:55 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix allmodconfig breakage

On Sun, Oct 26, 2008 at 05:12:34AM +0000, Al Viro wrote:
> 	If you use KCONFIG_ALLCONFIG (even with empty file) you get
> broken allmodconfig/allyesconfig; CONFIG_MODULES gets turned off,
> with obvious massive fallout.
> 
> 	Breakage had been introduced when conf_set_all_new_symbols()
> got used for allmodconfig et.al.
> 
> 	What happens is that sym_calc_value(modules_sym) done in
> conf_read_simple() sets SYMBOL_VALID on both modules_sym and MODULES.
> When we get to conf_set_all_new_symbols(), we set sym->def[S_DEF_USER]
> on everything, but it has no effect on sym->curr for the symbols that
> already have SYMBOL_VALID - these are stuck.
> 
> 	Solution: use sym_clear_all_valid() in there.  Note that it
> makes reevaluation of modules_sym redundant - sym_clear_all_valid()
> will do that itself.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=11512

> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index b91cf24..830d9ea 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -852,8 +852,7 @@ void conf_set_all_new_symbols(enum conf_def_mode mode)
>  
>  	}
>  
> -	if (modules_sym)
> -		sym_calc_value(modules_sym);
> +	sym_clear_all_valid();
>  
>  	if (mode != def_random)
>  		return;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/