lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Oct 2008 11:06:35 +0900 From: Tejun Heo <tj@...nel.org> To: Mikael Pettersson <mikpe@...uu.se> CC: jgarzik@...ox.com, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...nel.org Subject: Re: [PATCH 2.6.28-rc2] sata_promise: proper hardreset Hello, Mikael. Mikael Pettersson wrote: > +static int pdc_pata_hardreset(struct ata_link *link, unsigned int *class, > + unsigned long deadline) > +{ > + pdc_reset_port(link->ap); > + return 0; > +} You either need to return -EAGAIN here to ask for follow-up SRST or override softreset. I think pdc_reset_port() doesn't actually reset the ATA channel, right? In that case, the latter would be the correct thing to do. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists