linux-kernel - Re: [PATCH 1/2] headers: move release_kernel_lock(), reacquire_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Oct 2008 17:42:55 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Christoph Hellwig <hch@...radead.org>, torvalds@...l.org,
	viro@...iv.linux.org.uk, acme@...stprotocols.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] headers: move release_kernel_lock(),
	reacquire_kernel_lock() to sched.c


* Alexey Dobriyan <adobriyan@...il.com> wrote:

> On Wed, Oct 29, 2008 at 06:04:37AM -0400, Christoph Hellwig wrote:
> > On Wed, Oct 29, 2008 at 07:18:27AM +0100, Ingo Molnar wrote:
> > > please dont move #ifdefs and interfaces into a .c file - if then move 
> > > it into another header file.
> > 
> > Sorry, but that makes no sense at all.  This stuff is implementation
> > private to sched.c, and adding some header for it is just braindead.
> 
> Well, yes, that was the logic behind move -- keep it private to scheduler.

i have no objections at all against the whole sched.h cleanup 
(reducing header file dependencies is a much needed activity). But 
please keep it in a header file - i.e. put it into 
kernel/sched_internals.h. (like we do it for 
kernel/lockdep_internals.h)

that could then probably be merged with kernel/sched_stats.h as well. 
(which too is an #ifdef laden interface piece of code we have moved 
into a header)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/