linux-kernel - Re: [PATCH] Fix hid_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 00:23:32 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andreas Schwab <schwab@...e.de>
Cc:	linux-kernel@...r.kernel.org, linux-input@....kernel.org
Subject: Re: [PATCH] Fix hid_device_id for cross compiling

On Sun, 26 Oct 2008 00:30:18 +0200 Andreas Schwab <schwab@...e.de> wrote:

> struct hid_device_id contains hidden padding which is bad for cross
> compiling.  Make the padding explicit and consistent across
> architectures.
> 

What is "bad" about it?  Can you expand a bit on the problem which is
being fixed here?  Before-and-after user-visible behaviour?

Thanks.

> ---
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index eb71b45..0e4f303 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -135,6 +135,7 @@ struct usb_device_id {
>  
>  struct hid_device_id {
>  	__u16 bus;
> +	__u16 pad1;
>  	__u32 vendor;
>  	__u32 product;
>  	kernel_ulong_t driver_data

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/