linux-kernel - Re: [PATCH] block: add timer on blkdev_dequeue_request() not elv_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 18:34:05 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Mike Anderson <andmike@...ux.vnet.ibm.com>
CC:	Jens Axboe <jens.axboe@...cle.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	IDE/ATA development list <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] block: add timer on blkdev_dequeue_request() not	elv_next_request()

Mike Anderson wrote:
> Jens Axboe <jens.axboe@...cle.com> wrote:
>> On Thu, Oct 30 2008, Tejun Heo wrote:
>>> Jens Axboe wrote:
>>>> That's actually a pretty dumb error, I'm surprised it hasn't reared its
>>>> ugly face in more ways. Presumably because the timeout is usually so
>>>> long, that we'll get to actually issuing and completing it within the
>>>> normal timeout anyway.
>>> Heh... it showed its ugly face in many different ways while I was
>>> playing with PMP connected via a very long eSATA cable.
>> Ah :-)
>>
>> If we had it wired up for eg the old IDE drivers, it would have shown up
>> quite quickly as well I think.
> 
> I am getting errors now and my system will not boot up. The system is
> connected to storage with active / passive paths. If we are doing a
> BLKPREP_KILL we will call elv_dequeue_request which will add the
> timer for the request we are killing. 
> 
> The attached patch is a quick patch to work around my issue, but we
> probably need something better. I would like to run some short timeout
> testing on it for a while (though that previously did not catch Tejun's
> issue). I will look at this more tomorrow unless someone beats me to it.

Aieee... I'm now trying to clean up the command fetch/completion
interface.  Please give me a day or two.  I'll clean it all up.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/