linux-kernel - [PATCH 0/4] cifs: fix oopses and mem corruption with concurrent mount/umount (try #4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 11:16:29 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	smfrench@...il.com
Cc:	smfrench@...tin.rr.com, linux-cifs-client@...ts.samba.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/4] cifs: fix oopses and mem corruption with concurrent mount/umount (try #4)

This patchset is intended to fix the oopses, memory corruption and mount
failures when using the reproducer detailed here:

https://bugzilla.samba.org/show_bug.cgi?id=5720

This is the fourth attempt at this. Since the third attempt, Steve
French has committed the patch to handle the server->tsk pointer more
atomically so that patch is ommitted here. While that patch helps ensure
that the shutdown of the demux thread happens cleanly, there are still
other races.

Andrew Morton has also taken the patch to clean up the server protocol
handling for -mm. I've included this patch in the set since Steve has
not yet taken it, and I've had to modify it slightly for changes that
have gone into Steve's tree.

This patchset is based on Steve French's cifs-2.6 git tree and should
apply cleanly to its current state.

The main differences in this patchset are that it fixes some bugs in
list handling in the earlier patchsets. It also reenables the sharing
of tree connects. With this, any structures that were previously
shared should remain so (no loss of functionality).

There's still some remaining cleanup work that can be done here. The
cifs_mount code could stand to be broken up into smaller functions.
cifs_debug_data_proc_show could also stand to be reorganized to better
reflect the heirarchy of server->session->tcon. Those changes are
probably more suitable in follow-on patches. I'd like to know whether
these are acceptible before I spend time working on them.

I've been able to run the reproducer in the above BZ overnight on this
patchset. Without it, it usually crashes within a few minutes.

Jeff Layton (4):
  cifs: clean up server protocol handling for TCP_Server_Info
  cifs: disable sharing session and tcon and add new TCP sharing code
  cifs: reinstate sharing of SMB sessions
  cifs: reinstate sharing of tree connections

 fs/cifs/cifs_debug.c |  286 +++++++++++++++++++---------------
 fs/cifs/cifsfs.c     |   33 +++--
 fs/cifs/cifsglob.h   |   28 ++--
 fs/cifs/cifssmb.c    |   54 +------
 fs/cifs/connect.c    |  426 +++++++++++++++++++++++++-------------------------
 fs/cifs/misc.c       |   93 +++++------
 6 files changed, 456 insertions(+), 464 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/