linux-kernel - Re: [PATCH][RESEND] tracing/ftrace: Remove unused code in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 Oct 2008 13:15:45 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RESEND] tracing/ftrace: Remove unused code in sched_switch tracer

2008/10/31 Frederic Weisbecker <fweisbec@...il.com>:
> When init_sched_switch_trace() is called, it has no reason to start
> the sched tracer if the sched_ref is not zero.
>
> _ If this is non-zero, the tracer is already used, but we can register it
> to the tracing engine. There is already a security which avoid the tracer
> probes not to be resgistered twice.
>
> _ If this is zero, this block will not be used.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> CC: Steven Rostedt <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_sched_switch.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
> diff --git a/kernel/trace/trace_sched_switch.c b/kernel/trace/trace_sched_switch.c
> index 59de514..96620c7 100644
> --- a/kernel/trace/trace_sched_switch.c
> +++ b/kernel/trace/trace_sched_switch.c
> @@ -203,14 +203,6 @@ static struct tracer sched_switch_trace __read_mostly =
>
>  __init static int init_sched_switch_trace(void)
>  {
> -       int ret = 0;
> -
> -       if (atomic_read(&sched_ref))
> -               ret = tracing_sched_register();
> -       if (ret) {
> -               pr_info("error registering scheduler trace\n");
> -               return ret;
> -       }
>        return register_tracer(&sched_switch_trace);
>  }
>  device_initcall(init_sched_switch_trace);
>

(depends on tracing/ftrace: Fix a race condition in sched_switch tracer)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/