linux-kernel - Re: [PATCH] libata: Avoid overflow in ata_tf_to_lba48() when tf->hba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 31 Oct 2008 01:45:48 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Roland Dreier <rdreier@...co.com>
CC:	Phillip O'Donnell <phillip.odonnell@...il.com>,
	Oskar Liljeblad <oskar@....mine.nu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata: Avoid overflow in ata_tf_to_lba48() when tf->hba_lbal
 > 127

Roland Dreier wrote:
> In ata_tf_to_lba48(), when evaluating
> 
> 	(tf->hob_lbal & 0xff) << 24
> 
> the expression is promoted to signed int (since int can hold all values
> of u8).  However, if hob_lbal is 128 or more, then it is treated as a
> negative signed value and sign-extended when promoted to u64 to | into
> sectors, which leads to the MSB 32 bits of section getting set
> incorrectly.
> 
> For example, Phillip O'Donnell <phillip.odonnell@...il.com> reported
> that a 1.5GB drive caused:
> 
>     ata3.00: HPA detected: current 2930277168, native 18446744072344861488
> 
> where 2930277168 == 0xAEA87B30 and 18446744072344861488 == 0xffffffffaea87b30
> which shows the problem when hob_lbal is 0xae.
> 
> Fix this by adding a cast to u64, just as is used by for hob_lbah and
> hob_lbam in the function.
> 
> Reported-by: Phillip O'Donnell <phillip.odonnell@...il.com>
> Signed-off-by: Roland Dreier <rolandd@...co.com>
> ---
> Phillip, this should fix at least your cosmetic issue; can you test it
> and report back?
> 
> Thanks,
>   Roland
> 
>  drivers/ata/libata-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/