linux-kernel - Re: [PATCH] kernel/cpu.c: Section mismatch warning fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Nov 2008 07:59:47 +0600
From:	"Rakib Mullick" <rakib.mullick@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kernel/cpu.c: Section mismatch warning fix.

On 10/31/08, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Rakib Mullick <rakib.mullick@...il.com> wrote:
>
>
> you've tested that on x86, right? Have you checked/reviewed all the
> non-x86 architecture codepaths:
>
>  ./arch/m32r/kernel/smpboot.c:	notify_cpu_starting(cpu_id);
>  ./arch/cris/arch-v32/kernel/smp.c:	notify_cpu_starting(cpu);
>  ./arch/s390/kernel/smp.c:	 notify_cpu_starting(smp_processor_id());
>  ./arch/x86/mach-voyager/voyager_smp.c:	notify_cpu_starting(cpuid);
>  ./arch/x86/kernel/smpboot.c:	notify_cpu_starting(cpuid);
>  ./arch/mips/kernel/smp.c:	notify_cpu_starting(cpu);
>  ./arch/sparc64/kernel/smp.c:	notify_cpu_starting(cpuid);
>  ./arch/ia64/kernel/smpboot.c:	notify_cpu_starting(cpuid);
>  ./arch/um/kernel/smp.c:	notify_cpu_starting(cpu);
>  ./arch/sparc/kernel/sun4d_smp.c:	notify_cpu_starting(cpuid);
>  ./arch/sparc/kernel/sun4m_smp.c:	notify_cpu_starting(cpuid);
>  ./arch/powerpc/kernel/smp.c:	notify_cpu_starting(cpu);
>  ./arch/alpha/kernel/smp.c:	notify_cpu_starting(cpuid);
>  ./arch/sh/kernel/smp.c:	notify_cpu_starting(smp_processor_id());
>  ./arch/arm/kernel/smp.c:	notify_cpu_starting(cpu);
>
> to make sure that they never use this function after free_initmem()?
Above codepaths are basically called during initialization, where all
the CPU's are initiated.
When we complete the initial bootup then free_initmem is called. So,
If i'm not wrong they're not using this function after
free_initmem().And notify_cpu_started(cpuid) is declared when
CPU_HOTPLUG is not set. So, It's safe also from CPU hotpluging POV. Am
I missing anything?

Rakib
>
> 	Ingo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/