linux-kernel - Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Nov 2008 07:22:02 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Mike Frysinger <vapier@...too.org>
Cc:	alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments

At Thu,  6 Nov 2008 21:05:21 -0500,
Mike Frysinger wrote:
> 
> The snd_BUG_ON() macro should always expand its argument even if we're
> forcing it to false.  This kills off unused warnings that did not exist
> before the snd_assert() -> snd_BUG_ON() conversion.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>

Andrew already change this differently.  Check with the latest version.
And which warning did you get actually?


thanks,

Takashi

> ---
>  include/sound/core.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 35424a9..87de9fc 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -387,7 +387,7 @@ void snd_verbose_printd(const char *file, int line, const char *format, ...)
>  
>  #define snd_printd(fmt, args...)	/* nothing */
>  #define snd_BUG()			/* nothing */
> -#define snd_BUG_ON(cond)	({/*(void)(cond);*/ 0;})  /* always false */
> +#define snd_BUG_ON(cond)	((cond) && 0)  /* always false */
>  
>  #endif /* CONFIG_SND_DEBUG */
>  
> -- 
> 1.6.0.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/