linux-kernel - Re: [PATCH -v3 2/4] vm: use new has_capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 07 Nov 2008 10:39:04 -0500
From:	Stephen Smalley <sds@...ho.nsa.gov>
To:	Eric Paris <eparis@...hat.com>
Cc:	linux-kernel@...r.kernel.org, selinux@...ho.nsa.gov,
	linux-security-module@...r.kernel.org, jmorris@...eil.org,
	serue@...ibm.com, morgan@...nel.org, casey@...aufler-ca.com,
	esandeen@...hat.com
Subject: Re: [PATCH -v3 2/4] vm: use new has_capability_noaudit

On Fri, 2008-11-07 at 10:23 -0500, Eric Paris wrote:
> The oomkiller calculations make decisions based on capabilities.  Since
> these are not security decisions and LSMs should not record if they fall
> the request they should use the new has_capability_noaudit() interface so
> the denials will not be recorded.
> 
> Signed-off-by: Eric Paris <eparis@...hat.com>

Acked-by:  Stephen Smalley <sds@...ho.nsa.gov>

> ---
> 
>  mm/oom_kill.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index a0a0190..df259c2 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -128,8 +128,8 @@ unsigned long badness(struct task_struct *p, unsigned long uptime)
>  	 * Superuser processes are usually more important, so we make it
>  	 * less likely that we kill those.
>  	 */
> -	if (has_capability(p, CAP_SYS_ADMIN) ||
> -	    has_capability(p, CAP_SYS_RESOURCE))
> +	if (has_capability_noaudit(p, CAP_SYS_ADMIN) ||
> +	    has_capability_noaudit(p, CAP_SYS_RESOURCE))
>  		points /= 4;
>  
>  	/*
> @@ -138,7 +138,7 @@ unsigned long badness(struct task_struct *p, unsigned long uptime)
>  	 * tend to only have this flag set on applications they think
>  	 * of as important.
>  	 */
> -	if (has_capability(p, CAP_SYS_RAWIO))
> +	if (has_capability_noaudit(p, CAP_SYS_RAWIO))
>  		points /= 4;
>  
>  	/*
-- 
Stephen Smalley
National Security Agency

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/