linux-kernel - [PATCH][RT] Trivial: Correctly dereference when clearing unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 07 Nov 2008 13:19:42 -0800
From:	Sven-Thorsten Dietrich <sven@...bigcorporation.com>
To:	RT Users List <linux-rt-users@...r.kernel.org>
Cc:	LKML <Linux-kernel@...r.kernel.org>, Tony Jones <tonyj@...e.de>
Subject: [PATCH][RT] Trivial: Correctly dereference when clearing unused
	variable



From: Sven-Thorsten Dietrich <sdietrich@...e.de>
Subject:  Correctly dereference flags when clearing unused variable.

Its probably unsafe to set the flags pointer to 0, since this will oops,
if it is dereferenced elsewhere for some odd reason. 

Signed-off-by: Sven-Thorsten Dietrich <sdietrich@...e.de>

---
 mm/page_alloc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -170,7 +170,7 @@ static inline void __lock_cpu_pcp(unsign
 {
 #ifdef CONFIG_PREEMPT_RT
 	spin_lock(&__get_cpu_lock(pcp_locks, cpu));
-	flags = 0;
+	*flags = 0;
 #else
 	local_irq_save(*flags);
 #endif
@@ -180,7 +180,7 @@ static inline void lock_cpu_pcp(unsigned
 {
 #ifdef CONFIG_PREEMPT_RT
 	(void)get_cpu_var_locked(pcp_locks, this_cpu);
-	flags = 0;
+	*flags = 0;
 #else
 	local_irq_save(*flags);
 	*this_cpu = smp_processor_id();


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/