linux-kernel - Re: [PATCH 2/4 v1] i.MX31: Image Processing Unit DMA and IRQ drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 10:36:24 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	linux-kernel@...r.kernel.org
cc:	maciej.sosnowski@...el.com, dan.j.williams@...el.com,
	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Subject: Re: [PATCH 2/4 v1] i.MX31: Image Processing Unit DMA and IRQ drivers

(moved to LKML and added Haavard as the author of dw_dmac and DMA_SLAVE 
support to cc:)

On Fri, 7 Nov 2008, Guennadi Liakhovetski wrote:

> Now to the problems I encountered with the dmaengine framework. Basically 
> I was unable to find out how I can release specific transfer-descriptors 
> without using ->device_terminate_all(), and channels without unregistering 
> the client.
> 
> I did see the DMA_CTRL_ACK flag, but it looks like it is used 
> inconsistently in various drivers. In the header it is described as
> 
>  * @DMA_CTRL_ACK - the descriptor cannot be reused until the client
>  * 	acknowledges receipt, i.e. has has a chance to establish any
>  * 	dependency chains
> 
> but I haven't found any way to actually "acknowledge receipt" of the 
> descriptor. There are two macros in dmaengine.h: async_tx_ack() and 
> async_tx_test_ack() but their implementation doesn't look right: 
> async_tx_ack() does just
> 
> 	tx->flags |= DMA_CTRL_ACK;
> 
> and async_tx_test_ack()
> 
> 	return (tx->flags & DMA_CTRL_ACK) == DMA_CTRL_ACK;
> 
> So, instead of using this flag to say "do not release until acked" it now 
> means "acked, can be released?" In ipu_idmac.c I have to be able to 
> release specific transfer-descriptors, so, I added a .tx_free() pointer to 
> struct dma_async_tx_descriptor.
> 
> As for releasing channels - there is a dma_chan_cleanup() function, which 
> calls the .device_free_chan_resources() method in struct dma_device and 
> decremts channel's refcount, but this doesn't seem to lead to the 
> chan->client_count counter being decremented, i.e., 
> dma_clients_notify_removed() never gets called as it, probably, should be. 
> I have no solution to this problem, so, releasing specific channels in 
> ipu_idmac.c currently doesn't work.

I still have no solution to this ->client_count problem. Is this a bug and 
there should be a way to release a channel (including decrementint the 
client_count) without unregistering the client, or am I missing something?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/