linux-kernel - Re: [PATCH] cciss: firmware version is invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Nov 2008 18:29:40 -0700
From:	Tim Gardner <tim.gardner@...onical.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	tcanonical@....com, bryan.stillwell@...com, Mike.Miller@...com,
	iss_storagedev@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cciss: firmware version is invalid

Andrew Morton wrote:
> On Fri, 07 Nov 2008 07:12:08 -0700
> Tim Gardner <tcanonical@....com> wrote:
> 
>> Stillwell, Bryan wrote:
>>> Tim,
>>>
>>> Thanks for getting this merged, but I believe this patch is preferred
>>> over the original one I attached:
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/broken-out/cciss-fix-regression-firmware-not-displayed-in-procfs-again-and-again.patch
>>>
>>> The reason for this according to Mike Miller is: "The first fix could be
>>> called anytime something changed on the controller such as number of
>>> logical volumes, etc.  This patch will get called only once for each
>>> controller."
>>>
>>> Thanks,
>>> Bryan
>> applied
>>
> 
> I'm all confused here.
> 
> cciss-fix-regression-firmware-not-displayed-in-procfs-again-and-again.patch
> is now in mainline.  Are you saying that "cciss: Firmware Version is
> invalid" is preferred?  That "cciss: Firmware Version is invalid"
> should still be applied?
> 
> If so, "cciss: Firmware Version is invalid" will need a better title
> and changelog, please.  The one you have there is pretty skimpy. 
> reading between the lines, I'm guessing that the driver emits "Firmware
> Version is invalid" messages and that this patch somehow fixes that?
> 

Andrew,

The patch in Linus' repo looks correct, so please drop this one. At the
time I sent the original patch I didn't realize there was another
version already staged for Linus.

rtg
-- 
Tim Gardner tim.gardner@...onical.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/