linux-kernel - Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 14:58:20 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Jordan Crouse <jordan.crouse@....com>,
	Andres Salomon <dilinger@...ian.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE_LX

At Tue, 11 Nov 2008 14:53:06 +0100,
Ingo Molnar wrote:
> 
> 
> * Takashi Iwai <tiwai@...e.de> wrote:
> 
> > At Tue, 11 Nov 2008 13:54:02 +0100,
> > Ingo Molnar wrote:
> > > 
> > > 
> > > * Takashi Iwai <tiwai@...e.de> wrote:
> > > 
> > > > The OLPC-specpfic codes require geode_gpio_*() functions although
> > > > these functions are defined only with CONFIG_MGEODE_LX=y.
> > > > Add a proper dependency to fix build errors.
> > > > 
> > > > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> > > 
> > > hm, could you please send a .config that shows the build errors?
> > 
> > Here it is.  It's for today's linux-next.
> 
> hm, which tree did that build failure in linux-next originate from? 
> Your config builds fine here with the latest x86 tree.

Ah, sorry, forgot to mention that the build error comes from the
latest ALSA code.  It contains an OLPC-specific code that is enabled
via CONFIG_OLPC like:

	snd-cs5535audio-$(CONFIG_OLPC) += cs5535audio_olpc.o

where this includes geode_gpio_*() calls.

Of course, I can add an if in Makefile or create a new Kconfig,
but since asm/olpc.h itself includes asm/geode.h and contains
geode_gpio*() calls, it would be a proper fix to make CONFIG_OLPC
dependent on geode.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/