linux-kernel - [PATCH] drivers/firmware/memmap.c: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 19:25:18 +0100
From:	"Thomas De Schampheleire" <patrickdepinguin@...il.com>
To:	linux-kernel@...r.kernel.org,
	kernel-janitors <kernel-janitors@...ts.osdl.org>
Subject: [PATCH] drivers/firmware/memmap.c: fix sparse warnings

This patch fixes the following sparse warnings:
  CHECK   drivers/firmware/memmap.c
  drivers/firmware/memmap.c:59:25: warning: symbol 'memmap_start_attr'
was not declared. Should it be static?
  drivers/firmware/memmap.c:60:25: warning: symbol 'memmap_end_attr'
was not declared. Should it be static?
  drivers/firmware/memmap.c:61:25: warning: symbol 'memmap_type_attr'
was not declared. Should it be static?

Signed-off-by: Thomas De Schampheleire <patrickdepinguin@...il.com>
---
 drivers/firmware/memmap.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
index 3bf8ee1..261b9aa 100644
--- a/drivers/firmware/memmap.c
+++ b/drivers/firmware/memmap.c
@@ -56,9 +56,9 @@ struct memmap_attribute {
        ssize_t (*show)(struct firmware_map_entry *entry, char *buf);
 };

-struct memmap_attribute memmap_start_attr = __ATTR_RO(start);
-struct memmap_attribute memmap_end_attr   = __ATTR_RO(end);
-struct memmap_attribute memmap_type_attr  = __ATTR_RO(type);
+static struct memmap_attribute memmap_start_attr = __ATTR_RO(start);
+static struct memmap_attribute memmap_end_attr   = __ATTR_RO(end);
+static struct memmap_attribute memmap_type_attr  = __ATTR_RO(type);

 /*
  * These are default attributes that are added for every memmap entry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/