[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2008 20:04:30 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Isaku Yamahata <yamahata@...inux.co.jp>,
Jeremy Fitzhardinge <jeremy@...p.org>,
Tony Luck <tony.luck@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c
At Tue, 11 Nov 2008 10:47:24 -0800,
Jeremy Fitzhardinge wrote:
>
> Takashi Iwai wrote:
> > At Tue, 11 Nov 2008 09:43:27 -0800,
> > Jeremy Fitzhardinge wrote:
> >
> >> Isaku Yamahata wrote:
> >>
> >>> Here is.
> >>>
> >>> __initdata and const cannot be always a happy pair and
> >>> x86 xen has the potential issue.
> >>> This patch simply removes const from data with __initdata
> >>> under arch/x86/xen/.
> >>>
> >>>
> >> No, I think the proper fix is to use __initconst.
> >>
> >
> > The problem is that it depends on gcc version which section it goes.
> > Thus __initconst could break some gcc versions as well.
> >
>
> Why? __initconst explicitly puts it in .init.rodata.
Hrm, right, that's what __initconst does. Just confused.
Then I'm wondering in which case __initconst can be broken...
Sam? Do you have any particular reports?
Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists