linux-kernel - Re: [PATCH] VFS: lseek(fd, 0, SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 07:37:54 +0100
From:	Alain Knaff <alain@...ff.lu>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] VFS: lseek(fd, 0, SEEK_CUR) race condition

Andrew Morton wrote:
[...]
> OK, I think that a concurrent lseek(fd, 0, SEEK_CUR) is a sufficiently
> sane operation that this is worth doing.  As you point out, there is no
> other way of userspace doing what is effectively a read-only operation
> - userspace would be entitled to wonder "ytf did the kernel rewrite the
> file offset for that?".
> 
> 
> Do the below additions look OK?

Yes, these additions look ok to me. Thanks for your quick and easy reply.

> From: Andrew Morton <akpm@...ux-foundation.org>
> 
> - fix coding-style
> - fix default_llseek() as well

Wow, that one was missing an unlock_kernel()... I'm wondering why this
hadn't let to some major SNAFU...

> - add comments

Thanks,

Alain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/