linux-kernel - Re: [PATCH 2/2] tracing/function-return-tracer: Call prepare_ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Nov 2008 10:38:58 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Steven Rostedt" <rostedt@...dmis.org>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tracing/function-return-tracer: Call prepare_ftrace_return by registers

2008/11/13 Ingo Molnar <mingo@...e.hu>:
> hm, function-exit is a quite bad name i think that tells nothing to
> the user. I like "function-cost tracer" because that tells the user
> what it's all about in the end.
>
> Or perhaps we could name it the "callgraph" tracer? (as opposed to the
> simpler function tracer which traces function entries) Note that we
> could use the output to build function call coverage graphs.

But you can build a call graph with the function tracer, that what
does the script draw_trace.py
in a bit loosely way for example.
IMHO, function cost measurement or call graphs are particular uses
that can be made of this engine.
You can also use it to trace function return values for example.

The general sense of this is more about return hooking.
But....
Perhaps defining it as a "return" tracer is not easy to understand at
a first sight and could bring developpers
on misinterpretation (sorry does this word exist?).

So perhaps naming it by thinking on the purpose it could be use at
most would be better that its "general" or "potential"
purpose. I don't know...

> It definitely must convey the idea that this is a more capable (and
> also more expensive) form of function tracing.
>
>        Ingo
>

If we convey/consider it on a sight where it is capable on several
things, so a more generic name should be chosen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/