| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Nov 2008 12:27:46 -0800 From: Arjan van de Ven <arjan@...radead.org> To: Hugh Dickins <hugh@...itas.com> Cc: linux-kernel@...r.kernel.org, htejun@...il.com, akpm@...ux-foundation.org, jens.axboe@...cle.com Subject: Re: [PATCH] Fix kunmap() argument in sg_miter_stop On Sat, 15 Nov 2008 20:15:15 +0000 (GMT) Hugh Dickins <hugh@...itas.com> wrote: > On Sat, 15 Nov 2008, Arjan van de Ven wrote: > > >From fd5530ac75a919a20bf7951e90a2b12323e9c0a0 Mon Sep 17 00:00:00 > > >2001 > > From: Arjan van de Ven <arjan@...ux.intel.com> > > Date: Sat, 15 Nov 2008 11:23:58 -0800 > > Subject: [PATCH] Fix kunmap() argument in sg_miter_stop > > > > kunmap() takes as argument the struct page that orginally got > > kmap()'d, however the sg_miter_stop() function passed it the kernel > > virtual address instead, resulting in "kernel BUG at > > arch/x86/mm/highmem_32.c:115!" > > Your patch looks like a good fix to me, but I don't get how its bug > would manifest as highmem_32.c:115 - that's a check in > kunmap_atomic(), whereas you're fixing a bad address to kunmap(). > blarg this is a new dimension to "off by one bug" L( -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists