linux-kernel - [patch] x86, bts: fix unlock problem in ds.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Nov 2008 11:00:17 +0100
From:	Markus Metzger <markus.t.metzger@...glemail.com>
To:	lkml <linux-kernel@...r.kernel.org>
Cc:	work <markus.t.metzger@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	stephane eranian <eranian@...glemail.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>
Subject: [patch] x86, bts: fix unlock problem in ds.c

Fix a problem where ds_request() returned an error without releasing the
ds lock.

Reported-by: Stephane Eranian <eranian@...il.com>
Signed-off-by: Markus Metzger <markus.t.metzger@...il.com>
---

Index: gits/arch/x86/kernel/ds.c
===================================================================
--- gits.orig/arch/x86/kernel/ds.c	2008-11-15 10:51:51.000000000 +0100
+++ gits/arch/x86/kernel/ds.c	2008-11-15 10:53:43.000000000 +0100
@@ -384,8 +384,9 @@
 
 	spin_lock(&ds_lock);
 
+	error = -EPERM;
 	if (!check_tracer(task))
-		return -EPERM;
+		goto out_unlock;
 
 	error = -ENOMEM;
 	context = ds_alloc_context(task);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/