lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Nov 2008 20:38:55 +0800 From: Yu Zhao <yu.zhao@...scape.net> To: Matthew Wilcox <matthew@....cx> CC: "Zhao, Yu" <yu.zhao@...el.com>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, Jesse Barnes <jbarnes@...tuousgeek.org>, Randy Dunlap <randy.dunlap@...cle.com>, Grant Grundler <grundler@...isc-linux.org>, Alex Chiang <achiang@...com>, Roland Dreier <rdreier@...co.com>, Greg KH <greg@...ah.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org> Subject: Re: [PATCH 6/6 v3] PCI: document the change Matthew Wilcox wrote: > On Sat, Sep 27, 2008 at 04:28:45PM +0800, Zhao, Yu wrote: >> +To register SR-IOV service, Physical Function device driver needs to call: >> + int pci_iov_register(struct pci_dev *dev, >> + int (*notify)(struct pci_dev *, u32), char **entries) > > I think a better interface would put the 'notify' into the struct > pci_driver. That would make 'notify' a bad name .... how about > 'virtual'? There's also no documentation for the second parameter to > 'notify'. Yes, putting the callback function to the 'pci_driver' is better. Looks like the 'virtual' is not very descriptive (and it's a adj. while other callbacks are verb). Any other candidates? Thanks, Yu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists