linux-kernel - Re: [PATCH, 2.6.28-rc5] unitialized return value in mm/mlock.c: __mlock_vma_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Nov 2008 15:55:10 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Helge Deller <deller@....de>
cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Kyle Mc Martin <kyle@...a.kernel.org>,
	linux-parisc@...r.kernel.org, linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH, 2.6.28-rc5] unitialized return value in mm/mlock.c:
 __mlock_vma_pages_range()

On Mon, 17 Nov 2008, Helge Deller wrote:
>
> Fix an unitialized return value when compiling on parisc (with CONFIG_UNEVICTABLE_LRU=y):
> 	mm/mlock.c: In function `__mlock_vma_pages_range':
> 	mm/mlock.c:165: warning: `ret' might be used uninitialized in this function

Looks valid.

Of course, nobody should ever call this with a range that could possibly 
be empty, so an equally valid approach would be to change the "while" loop 
to a "do while()", and that would generate better code. But I guess the 
simple unnecessary initialization is more defensive programming, in that 
if some other buggy caller does set things up with an empty range, it gets 
the right result.

Btw, exactly _because_ gcc warnings about uninitialized functions are 
sometimes bogus (ie due to gcc simply not being able to follow things like 
conditional initializations where the values are only used if they were 
initialized), I would ask that people comment on these kinds of issues 
when they send in patches. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/