linux-kernel - RE: [patch 2.6.28-rc5] mfd da903x: section fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Nov 2008 17:18:29 -0800
From:	"Eric Miao" <ymiao3@...vell.com>
To:	<dbrownell@...rs.sourceforge.net>,
	"Samuel Ortiz" <sameo@...nedhand.com>
Cc:	"lkml" <linux-kernel@...r.kernel.org>,
	"Mike Rapoport" <mike@...pulab.co.il>
Subject: RE: [patch 2.6.28-rc5] mfd da903x: section fix

Indeed.

Acked-by: Eric Miao <eric.miao@...vell.com>

Samuel, please consider merge, thanks.

-----Original Message-----
From: David Brownell [mailto:david-b@...bell.net] 
Sent: Tuesday, November 18, 2008 3:43 AM
To: Samuel Ortiz
Cc: lkml; Eric Miao; Mike Rapoport
Subject: [patch 2.6.28-rc5] mfd da903x: section fix

From: David Brownell <dbrownell@...rs.sourceforge.net>

This fixes the following section warning:

  WARNING: vmlinux.o(.devinit.text+0x3d36): Section mismatch in
reference from the function 
  da903x_add_subdevs() to the function
.devexit.text:da903x_remove_subdevs()
  The function __devinit da903x_add_subdevs() references
  a function __devexit da903x_remove_subdevs().
  This is often seen when error handling in the init function
  uses functionality in the exit path.
  The fix is often to remove the __devexit annotation of
  da903x_remove_subdevs() so it may be used outside an exit section.

It might be nice to have an "init and exit" section annotation for such
cases; in this case the waste is only about 40 bytes (x86 test build).

Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
---
 drivers/mfd/da903x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/mfd/da903x.c
+++ b/drivers/mfd/da903x.c
@@ -435,13 +435,13 @@ static const struct i2c_device_id da903x
 };
 MODULE_DEVICE_TABLE(i2c, da903x_id_table);

-static int __devexit __remove_subdev(struct device *dev, void *unused)
+static int __remove_subdev(struct device *dev, void *unused)
 {
 	platform_device_unregister(to_platform_device(dev));
 	return 0;
 }

-static int __devexit da903x_remove_subdevs(struct da903x_chip *chip)
+static int da903x_remove_subdevs(struct da903x_chip *chip)
 {
 	return device_for_each_child(chip->dev, NULL, __remove_subdev);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/