lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Nov 2008 09:25:53 +0800 From: "Ming Lei" <tom.leiming@...il.com> To: "Andrew Morton" <akpm@...ux-foundation.org> Cc: kay.sievers@...y.org, greg@...ah.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] kernel/ksysfs.c:fix dependence on CONFIG_NET 2008/11/19 Andrew Morton <akpm@...ux-foundation.org>: > On Tue, 18 Nov 2008 15:38:18 -0800 > Andrew Morton <akpm@...ux-foundation.org> wrote: > >> On Sun, 16 Nov 2008 18:22:09 +0800 >> tom.leiming@...il.com wrote: >> >> > From: Ming Lei <tom.leiming@...il.com> >> > >> > Access to uevent_seqnum and uevent_helper does not need to >> > depend on CONFIG_NET, so remove it. >> > >> > Signed-off-by: Ming Lei <tom.leiming@...il.com> >> > --- >> > kernel/ksysfs.c | 4 ++-- >> > 1 files changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c >> > index 08dd8ed..528dd78 100644 >> > --- a/kernel/ksysfs.c >> > +++ b/kernel/ksysfs.c >> > @@ -24,7 +24,7 @@ static struct kobj_attribute _name##_attr = __ATTR_RO(_name) >> > static struct kobj_attribute _name##_attr = \ >> > __ATTR(_name, 0644, _name##_show, _name##_store) >> > >> > -#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET) >> > +#if defined(CONFIG_HOTPLUG) >> > /* current uevent sequence number */ >> > static ssize_t uevent_seqnum_show(struct kobject *kobj, >> > struct kobj_attribute *attr, char *buf) >> > @@ -137,7 +137,7 @@ struct kobject *kernel_kobj; >> > EXPORT_SYMBOL_GPL(kernel_kobj); >> > >> > static struct attribute * kernel_attrs[] = { >> > -#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET) >> > +#if defined(CONFIG_HOTPLUG) >> > &uevent_seqnum_attr.attr, >> > &uevent_helper_attr.attr, >> > #endif >> >> I think the story here is that uevent uses netlink, and with >> CONFIG_NET=n, we have no netlink, so that code couldn't do anything >> anyway. >> > > Or not. Perhaps we can still use uevent_helper in this case? yes. > > (Getting a bit tired of writing people's changelogs for them!) > -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists